[ 
https://issues.apache.org/jira/browse/HDFS-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614882#comment-14614882
 ] 

Vinayakumar B commented on HDFS-8495:
-------------------------------------

{noformat}./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAppendOp.java:164:23:
 More than 7 parameters (found 8).{noformat}
This checkstyle comment also can be avoided.
Remove {{src}} argument from {{FSDirAppendOp.prepareFileForAppend(..)}} and get 
it using {{src = iip.getPath();}}.

+1 once this is addressed.

> Consolidate append() related implementation into a single class
> ---------------------------------------------------------------
>
>                 Key: HDFS-8495
>                 URL: https://issues.apache.org/jira/browse/HDFS-8495
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8495-000.patch, HDFS-8495-001.patch, 
> HDFS-8495-002.patch, HDFS-8495-003.patch, HDFS-8495-003.patch, 
> HDFS-8495-004.patch
>
>
> This jira proposes to consolidate {{FSNamesystem#append()}} related methods 
> into a single class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to