[ 
https://issues.apache.org/jira/browse/HDFS-8622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623787#comment-14623787
 ] 

kanaka kumar avvaru commented on HDFS-8622:
-------------------------------------------

Thanks for the patch [~jagadesh.kiran], few comments

1) It seems empty directory case is not handled in the code. Please check and 
add test case for empty Directory too
2) I think , {{getContentSummaryList}} should be {{getContentSummaryMap}}
3) {{ getContentSummary(String path) }} javadoc need corrections
4) Please use try with resources for file write in test code 
{{TestOfflineImageViewerForContentSummary#createOriginalFSImage}}

> Implement GETCONTENTSUMMARY operation for WebImageViewe
> -------------------------------------------------------
>
>                 Key: HDFS-8622
>                 URL: https://issues.apache.org/jira/browse/HDFS-8622
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Jagadesh Kiran N
>            Assignee: Jagadesh Kiran N
>         Attachments: HDFS-8622-00.patch, HDFS-8622-01.patch
>
>
>  it would be better for administrators if {code} GETCONTENTSUMMARY {code} are 
> supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to