[
https://issues.apache.org/jira/browse/HDFS-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630746#comment-14630746
]
Walter Su commented on HDFS-8688:
---------------------------------
Sorry, My previous comment has big mistake.
-line 2707 take effect only if in safemode.-
-In general, addStoredBlock will NOT add block to neededReplications. We don't
have to change anything about it.-
*line 2707 will take effect when out of safemode.*
--------
bq. we make sure blockHasEnoughRacks will be called only when there is enough
liveReplicas.
when there is enough liveReplicas, but blockHasEnoughRacks() returns false. The
bock belongs to QUEUE_REPLICAS_BADLY_DISTRIBUTED level. It should be updated in
needReplications. Sorry I don't get your point.
> replace shouldCheckForEnoughRacks with hasClusterEverBeenMultiRack
> ------------------------------------------------------------------
>
> Key: HDFS-8688
> URL: https://issues.apache.org/jira/browse/HDFS-8688
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-8688.01.patch, HDFS-8688.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
