[
https://issues.apache.org/jira/browse/HDFS-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632021#comment-14632021
]
Jing Zhao commented on HDFS-8433:
---------------------------------
The 05 patch looks good to me. Maybe we can skip the testRead for now and
reenable it when the retry logic gets fixed. A nitty pick is there are two
unused imports in TestBlockTokenWithDFS. +1 after addressing the comments.
> blockToken is not set in constructInternalBlock and parseStripedBlockGroup in
> StripedBlockUtil
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-8433
> URL: https://issues.apache.org/jira/browse/HDFS-8433
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Walter Su
> Attachments: HDFS-8433-HDFS-7285.02.patch,
> HDFS-8433-HDFS-7285.05.patch, HDFS-8433.00.patch, HDFS-8433.01.patch,
> HDFS-8433.03.txt, HDFS-8433.04.patch
>
>
> The blockToken provided in LocatedStripedBlock is not used to create
> LocatedBlock in constructInternalBlock and parseStripedBlockGroup in
> StripedBlockUtil.
> We should also add ec tests with security on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)