[ 
https://issues.apache.org/jira/browse/HDFS-8794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liu updated HDFS-8794:
-------------------------
    Attachment: HDFS-8794.002.patch

[~arpitagarwal], no problem, thanks a lot for the review!   Update the patch to 
rename {{getCorruptReplicaBlockIds}}, it's a good then the function is not used 
inadvertently.

> Improve CorruptReplicasMap#corruptReplicasMap
> ---------------------------------------------
>
>                 Key: HDFS-8794
>                 URL: https://issues.apache.org/jira/browse/HDFS-8794
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-8794.001.patch, HDFS-8794.002.patch
>
>
> Currently we use {{TreeMap}} for {{corruptReplicasMap}}, actually the only 
> need sorted place is {{getCorruptReplicaBlockIds}} which is used by test.
> So we can use {{HashMap}}.
> From memory and performance view, {{HashMap}} is better than {{TreeMap}}, a 
> simliar optimization HDFS-7433. Of course we need to make few change to 
> {{getCorruptReplicaBlockIds}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to