[
https://issues.apache.org/jira/browse/HDFS-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636888#comment-14636888
]
Rakesh R commented on HDFS-8769:
--------------------------------
Thanks a lot [~walter.k.su] for the reviews.
bq. You might have to hack BlockIdGenerator so that you could create a
contiguous file with negative ID.
I could see {{SequentialBlockIdGenerator}} legacy block will grow to positive
integer and will throw exception on negative integer. Also,
{{SequentialBlockGroupIdGenerator}} blockGrpId will grow to negative integer
and will throw exception on positive integer. Since we have clear separation
for the legacy blocks and EC block groups, do we need to hijack and create a
contiguous file with negative ID. Instead I feel we could add tests to see the
generator is validating the range and throws {{IllegalStateException}} properly
in both the cases. Does this sound good to you?
> Erasure Coding: unit test for SequentialBlockGroupIdGenerator
> -------------------------------------------------------------
>
> Key: HDFS-8769
> URL: https://issues.apache.org/jira/browse/HDFS-8769
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Rakesh R
> Attachments: HDFS-8769-HDFS-7285-00.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
