[
https://issues.apache.org/jira/browse/HDFS-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640408#comment-14640408
]
kanaka kumar avvaru commented on HDFS-8695:
-------------------------------------------
Thanks for the patch [~anu]. Few comments,
1) {{BucketHandler#createBucket()}}: parsing remove ACLs is not required,
infact should result in error for unexpected parameter
2) {{BucketHandler#upadteBucket()}}: As per Design specification, right now no
plan to support Bucket quota. But BucketArgs extends VolumeArgs so, OzoneQuota
parameter in request can be invalidated as UnSupportedOperation for now
3) Also, can you update javadoc to describe current supported operation during
update Bucket so that we can validate the interface contract in implementation
4) A new {{BUCKET_NOT_FOUND}} error needs to be added in {{ErrorTable}}
5) {{BucketHandler#listBucket}} : as per design document, I think
OZONE_LIST_QUERY_BUCKET should list the buckets in a volume and supposed to be
handled in {{VolumeHandler#getVolumeInfo(...)}} (There is already a TODO to
handle this)
6) {{BucketHandler#listBucket}}: Can you remove javadoc on doProcess() to
improve readability as its already documented in BucketProcessTemplate
AFAIK {{OZONE_LIST_QUERY_SERVICE}} request should list the contents of a
container (Please correct me If not) i.e
* Volumes for user when called on root path
* Buckets list when called on Volume
* Objects list when called on Bucket
7) If so, {{BucketHandler.#listBucket}}: OZONE_LIST_QUERY_BUCKET has to be
replaced with OZONE_LIST_QUERY_SERVICE for getting getBucketInfoResponse()
> OzoneHandler : Add Bucket REST Interface
> ----------------------------------------
>
> Key: HDFS-8695
> URL: https://issues.apache.org/jira/browse/HDFS-8695
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: hdfs-8695-HDFS-7240.001.patch
>
>
> Add Bucket REST interface into Ozone server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
