[jira] [Commented] (HDFS-6697) Make NN lease soft and hard limits configurable

[Ming Ma (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646951#comment-14646951
 ] 

Ming Ma commented on HDFS-6697:
-------------------------------

Thanks [~andreina]! Can you clarify why in LeaseRenewer it needs to compare the 
configured soft limit with the default soft limit? Instead it can just set the 
renewal variable with the configured value.

{noformat}
    long leaseSoftLimit = dfsc.getConf().getleaseSoftLimitPeriod();
    if (leaseSoftLimit > 0) {
        final long half = leaseSoftLimit / 2;
        if (half < renewal) {
          this.renewal = half;
       }
    }
{noformat}

> Make NN lease soft and hard limits configurable
> -----------------------------------------------
>
>                 Key: HDFS-6697
>                 URL: https://issues.apache.org/jira/browse/HDFS-6697
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ming Ma
>            Assignee: J.Andreina
>         Attachments: HDFS-6697.1.patch, HDFS-6697.2.patch, HDFS-6697.3.patch
>
>
> For testing, NameNodeAdapter allows test code to specify lease soft and hard 
> limit via setLeasePeriod directly on LeaseManager. But NamenodeProxies.java 
> still use the default values.
>  
> It is useful if we can make NN lease soft and hard limit configurable via 
> Configuration. That will allow NamenodeProxies.java to use the configured 
> values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)