songwanging created HDFS-8840:
---------------------------------
Summary: Inconsistent log level practice
Key: HDFS-8840
URL: https://issues.apache.org/jira/browse/HDFS-8840
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.1, 2.5.2, 2.5.1, 2.6.0
Reporter: songwanging
Priority: Minor
In method "checkLogsAvailableForRead()" of class:
hadoop-2.7.1-src\hadoop-hdfs-project\hadoop-hdfs\src\main\java\org\apache\hadoop\hdfs\server\namenode\ha\BootstrapStandby.java
The log level is not correct, after checking "LOG.isDebugEnabled()", we should
use "LOG.debug(msg, e);", while now we use " LOG.fatal(msg, e);". Log level is
inconsistent.
the source code of this method is:
private boolean checkLogsAvailableForRead(FSImage image, long imageTxId, long
curTxIdOnOtherNode) {
...
} catch (IOException e) {
...
if (LOG.isDebugEnabled()) {
LOG.fatal(msg, e);
} else {
LOG.fatal(msg);
}
return false;
}
}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
