[ 
https://issues.apache.org/jira/browse/HDFS-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649834#comment-14649834
 ] 

Zhe Zhang commented on HDFS-8835:
---------------------------------

Thanks for sharing the feedback [~szetszwo].

HDFS-8487 (as well as HDFS-8653, HDFS-8605) just try to divide-and-conquer the 
(inevitable) inconvenience for the community to understand and accept the EC 
change. I feel this way is easier than absorbing the huge change all at once. 
As shown below (copied from HDFS-8728 [discussion | 
https://issues.apache.org/jira/browse/HDFS-8728?focusedCommentId=14619043&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14619043])
 the overall EC change becomes much smaller and less intrusive after pushing 
these changes to trunk first (I will do the rebase after HDFS-8499 revert).

{code}
Current HDFS-7285: 
2532 insertions(+), 1156 deletions(-) in blockmanagement
1826 insertions(+), 444 deletions(-) in namenode

Rebased:
1251 insertions(+), 201 deletions(-) in blockmanagement
1324 insertions(+), 168 deletions(-) in namenode
{code}

That said, I understand that git rebasing is a relatively new workflow and 
people have different preferences in absorbing changes. So more feedbacks are 
very welcome.

> Convert BlockInfoUnderConstruction as an interface
> --------------------------------------------------
>
>                 Key: HDFS-8835
>                 URL: https://issues.apache.org/jira/browse/HDFS-8835
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.7.1
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>
> Per discussion under HDFS-8499, this JIRA aims to convert 
> {{BlockInfoUnderConstruction}} as an interface and 
> {{BlockInfoContiguousUnderConstruction}} as its implementation. The HDFS-7285 
> branch will add {{BlockInfoStripedUnderConstruction}} as another 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to