[
https://issues.apache.org/jira/browse/HDFS-8856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654983#comment-14654983
]
Yi Liu commented on HDFS-8856:
------------------------------
+1, thanks Arpit.
I found a nit in {{getCompleteBlocksTotal}}, if you can modify it too, that
would be nice.
{code}
readLock();
numUCBlocks = leaseManager.getNumUnderConstructionBlocks();
{code}
It's better to put {{readLock}} below
> Make LeaseManager#countPath O(1)
> --------------------------------
>
> Key: HDFS-8856
> URL: https://issues.apache.org/jira/browse/HDFS-8856
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.7.2
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8856.01.patch
>
>
> {{LeaseManager#countPath}} loops over all existing lease holders to compute
> the pending lease count. We can just track the pending leased files so it
> runs in constant time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
