[
https://issues.apache.org/jira/browse/HDFS-8622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659537#comment-14659537
]
Akira AJISAKA commented on HDFS-8622:
-------------------------------------
Mostly looks good to me. Minor comments:
1. Would you reverse the order of setting content summary?
{code}
+ data[2] = getFileSize(f);
+ data[1] = 1;
{code}
2. Would you make the variables private and remove symLinkDirSummaryFromDFS,
which is unused?
{code}
+ static ContentSummary summaryFromDFS = null;
+ static ContentSummary emptyDirSummaryFromDFS = null;
+ static ContentSummary fileSummaryFromDFS = null;
+ static ContentSummary symLinkSummaryFromDFS = null;
+ static ContentSummary symLinkDirSummaryFromDFS =null;
{code}
> Implement GETCONTENTSUMMARY operation for WebImageViewer
> --------------------------------------------------------
>
> Key: HDFS-8622
> URL: https://issues.apache.org/jira/browse/HDFS-8622
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Jagadesh Kiran N
> Assignee: Jagadesh Kiran N
> Attachments: HDFS-8622-00.patch, HDFS-8622-01.patch,
> HDFS-8622-02.patch, HDFS-8622-03.patch, HDFS-8622-04.patch, HDFS-8622-05.patch
>
>
> it would be better for administrators if {code} GETCONTENTSUMMARY {code} are
> supported.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
