[
https://issues.apache.org/jira/browse/HDFS-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661490#comment-14661490
]
Rakesh R commented on HDFS-8643:
--------------------------------
On a second look, I think I understood your comment partially. IIUC you have
mentioned two cases:
bq. we have RPC packet limitation and a large number of snapshot list
IMHO the above mentioned BatchedRemoteIterator approach will help to address
this case.
bq. some long snapshot names can cause issue.
{{DirectorySnapshottableFeature#SNAPSHOT_LIMIT = 1 << 16}} 65536 number of
snapshots is the limit. Now, the proposed
{{SnapshottableDirectoryStatus#getSnapshotNames()}} list will again hit the RPC
packet limitation. Here also, I'm inclined to provide separate iterator API
like, {{BatchedRemoteIterator <String, String>
DistributedFileSystem#getSnapshotNames()}} which uses {{snapshotCounter}} for
indexing. Any suggestions?
> Add snapshot names list to SnapshottableDirectoryStatus
> -------------------------------------------------------
>
> Key: HDFS-8643
> URL: https://issues.apache.org/jira/browse/HDFS-8643
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-8643-00.patch, HDFS-8643-01.patch
>
>
> The idea of this jira to enhance {{SnapshottableDirectoryStatus}} by adding
> {{snapshotNames}} attribute into it, presently it has the {{snapshotNumber}}.
> IMHO this would help the users to get the list of snapshot names created.
> Also, the snapshot names can be used while renaming or deleting the snapshots.
> {code}
> org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus.java
> /**
> * @return Snapshot names for the directory.
> */
> public List <String> getSnapshotNames() {
> return snapshotNames;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
