[
https://issues.apache.org/jira/browse/HDFS-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663273#comment-14663273
]
Zhe Zhang commented on HDFS-8854:
---------------------------------
Thanks Walter for updating the patch! Also appreciate the rebase effort. I
reviewed the "Consolidated-20150806.02" patch. The patch LGTM except for the
following minor issues.
* Better to fully describe the default policy: RS(6,3):
{code}
+ * With default 6+3 EC policy, each normal read could span 6 DNs. So this
{code}
* Should the name of an {{ErasureCodingPolicy}} be the schema name + cellSize?
Do we still need the {{name}} field? We do think about doing this as a
follow-on.
* A few Javadocs link issues:
{code}
+ * @return {@link org.apache.hadoop.hdfs.protocol.ErasureCodingPolicy}
{code}
So +1 pending the above and the comments from Rakesh.
> Erasure coding: add ECPolicy to replace schema+cellSize in hadoop-hdfs
> ----------------------------------------------------------------------
>
> Key: HDFS-8854
> URL: https://issues.apache.org/jira/browse/HDFS-8854
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-8854-Consolidated-20150806.02.txt,
> HDFS-8854-HDFS-7285.00.patch, HDFS-8854-HDFS-7285.01.patch,
> HDFS-8854-HDFS-7285.02.patch, HDFS-8854.00.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
