[
https://issues.apache.org/jira/browse/HDFS-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702088#comment-14702088
]
Aaron T. Myers commented on HDFS-8808:
--------------------------------------
Hey Zhe, latest patch looks pretty good to me. Just a few small comments:
# You should add an entry in {{hdfs-default.xml}} that describes what this
config setting does, and perhaps also amend the description of
{{dfs.image.transfer.bandwidthPerSec}} to make it clear that this does not
apply to bootstrapping the standby.
# It's kind of unfortunate that this patch is perpetuating the inconsistent
camel cased config name. I think much better would be to go with something
consistent with, for example, the block scanner config name, which uses
"bytes.per.second" instead of "bandwidthPerSec", which removes the camel case
and is more consistent. Of course, doing that would be inconsistent with
{{dfs.image.transfer.bandwidthPerSec}}. Perhaps we should go with being
consistent with the "bandwidthPerSec" style for now, but file a follow-up JIRA
to deprecate that form?
# Given that this JIRA will change the applicability of the existing config
name, I believe we should consider this an incompatible change. That said, I
think very few if any users are actually using the current config intending to
limit the bandwidth of bootstrapping the standby, so I'm personally OK putting
it into branch-2, but I still think we should mark this JIRA incompatible so as
to call it out appropriately.
# Nit: I think that "bootstrapping" should have two "p"s.
> dfs.image.transfer.bandwidthPerSec should not apply to -bootstrapStandby
> ------------------------------------------------------------------------
>
> Key: HDFS-8808
> URL: https://issues.apache.org/jira/browse/HDFS-8808
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.1
> Reporter: Gautam Gopalakrishnan
> Assignee: Zhe Zhang
> Attachments: HDFS-8808-00.patch, HDFS-8808-01.patch,
> HDFS-8808-02.patch, HDFS-8808-03.patch
>
>
> The parameter {{dfs.image.transfer.bandwidthPerSec}} can be used to limit the
> speed with which the fsimage is copied between the namenodes during regular
> use. However, as a side effect, this also limits transfers when the
> {{-bootstrapStandby}} option is used. This option is often used during
> upgrades and could potentially slow down the entire workflow. The request
> here is to ensure {{-bootstrapStandby}} is unaffected by this bandwidth
> setting
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
