[
https://issues.apache.org/jira/browse/HDFS-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717533#comment-14717533
]
Hadoop QA commented on HDFS-8938:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12752818/HDFS-8938.006.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / a9c8ea7 |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12171/console |
This message was automatically generated.
> Refactor BlockManager in blockmanagement
> ----------------------------------------
>
> Key: HDFS-8938
> URL: https://issues.apache.org/jira/browse/HDFS-8938
> Project: Hadoop HDFS
> Issue Type: Task
> Components: build
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-8938.000.patch, HDFS-8938.001.patch,
> HDFS-8938.002.patch, HDFS-8938.003.patch, HDFS-8938.004.patch,
> HDFS-8938.005.patch, HDFS-8938.006.patch
>
>
> This jira tracks the effort of refactoring inner classes
> {{BlockManager$BlockToMarkCorrupt}} and {{BlockManager$ReplicationWork}} in
> {{hdfs.server.blockmanagement}} package. As the line number of
> {{BlockManager}} is getting larger than 2000, we can move those two inner
> classes out of the it.
> Meanwhile, the logic in method {{computeReplicationWorkForBlocks}} can be
> simplified if we extract code sections to _schedule replication_ and to
> _validate replication work_ to private helper methods respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
