[
https://issues.apache.org/jira/browse/HDFS-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haohui Mai updated HDFS-8938:
-----------------------------
Description: This jira proposes to refactor two inner static classes,
{{BlockToMarkCorrupt}} and {{ReplicationWork}} from {{BlockManager}} to
standalone classes. The refactor also improves readability by abstracting the
complexity of scheduling and validating replications to corresponding helper
methods. (was: This jira tracks the effort of refactoring inner classes
{{BlockManager$BlockToMarkCorrupt}} and {{BlockManager$ReplicationWork}} in
{{hdfs.server.blockmanagement}} package. As the line number of {{BlockManager}}
is getting larger than 2000, we can move those two inner classes out of the it.
Meanwhile, the logic in method {{computeReplicationWorkForBlocks}} can be
simplified if we extract code sections to _schedule replication_ and to
_validate replication work_ to private helper methods respectively.)
> Extract BlockToMarkCorrupt and ReplicationWork as standalone classes from
> BlockManager
> --------------------------------------------------------------------------------------
>
> Key: HDFS-8938
> URL: https://issues.apache.org/jira/browse/HDFS-8938
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-8938.000.patch, HDFS-8938.001.patch,
> HDFS-8938.002.patch, HDFS-8938.003.patch, HDFS-8938.004.patch,
> HDFS-8938.005.patch, HDFS-8938.006.patch, HDFS-8938.007.patch
>
>
> This jira proposes to refactor two inner static classes,
> {{BlockToMarkCorrupt}} and {{ReplicationWork}} from {{BlockManager}} to
> standalone classes. The refactor also improves readability by abstracting the
> complexity of scheduling and validating replications to corresponding helper
> methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
