[
https://issues.apache.org/jira/browse/HDFS-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724102#comment-14724102
]
Zhe Zhang commented on HDFS-8982:
---------------------------------
Thanks Colin and Jing for the discussion.
Yes my intention was for us to take a look at all usages of the 2 methods and
remove inconsistencies.
>From a rough look, {{getPreferredBlockReplication}} should only be used in the
>{{namenode.snapshot}} package?
> Consolidate getFileReplication and getPreferredBlockReplication in INodeFile
> ----------------------------------------------------------------------------
>
> Key: HDFS-8982
> URL: https://issues.apache.org/jira/browse/HDFS-8982
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.7.1
> Reporter: Zhe Zhang
>
> Currently {{INodeFile}} provides both {{getFileReplication}} and
> {{getPreferredBlockReplication}} interfaces. At the very least they should be
> renamed (e.g. {{getCurrentFileReplication}} and
> {{getMaxConfiguredFileReplication}}), with clearer Javadoc.
> I also suspect we are not using them correctly in all places right now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
