[
https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-9002:
--------------------------------
Attachment: HDFS-9002.002.patch
The v002 patch rebases from trunk, fixes one javadoc warning, and resolves one
findbugs warning. The unit tests should have passed.
There is a findbugs warning in
{{org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslResponseWithNegotiatedCipherOption}}
class, as following:
{code}
<BugCategory category="MALICIOUS_CODE">
<Description>Malicious code vulnerability</Description>
</BugCategory>
<BugPattern category="MALICIOUS_CODE" abbrev="EI2" type="EI_EXPOSE_REP2"
cweid="374">
<ShortDescription>
May expose internal representation by incorporating reference to mutable object
</ShortDescription>
<Details>
<p> This code stores a reference to an externally mutable object into the
internal representation of the object. If instances are accessed by
untrusted code, and unchecked changes to the mutable object would compromise
security or other important properties, you will need to do something
different. Storing a copy of the object is better approach in many
situations.</p>
</Details>
</BugPattern>
<BugCode abbrev="EI2">
<Description>Storing reference to mutable object</Description>
</BugCode>
{code}
Before this jira, we exclude it in {{hadoop-hdfs}} module
{{dev-support/findbugsExcludeFile.xml}}. As we move this class to
{{hadoop-hdfs-client}} module, we should also exclude it the same way. If there
is any effort of fixing this, we should file a new jira.
> Move o.a.h.hdfs.net/*Peer classes to client module
> --------------------------------------------------
>
> Key: HDFS-9002
> URL: https://issues.apache.org/jira/browse/HDFS-9002
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: build
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9002.000.patch, HDFS-9002.001.patch,
> HDFS-9002.002.patch
>
>
> This jira tracks the effort of moving the following two parts to
> {{hadoop-hdfs-client}} module:
> * {{*Peer.java}} classes
> * static helper methods in {{TcpPeerServer}}
> In {{org.apache.hadoop.hdfs.net}} package, the {{Peer}} classes should be
> moved to {{hadoop-hdfs-client}} module as they are used in client, while
> {{PeerServer}} classes stay in {{hadoop-hdfs}} module. For the static helper
> methods in {{TcpPeerServer}}, we need to move them out of the
> {{TcpPeerServer}} class and put them in client module.
> Meanwhile, we need to move the related classes in
> {{org.apache.hadoop.hdfs.protocol.datatransfer.sasl}} packages as they're
> used by client module. Config keys should also be moved.
> The checkstyle warnings can be addressed in [HDFS-8979 |
> https://issues.apache.org/jira/browse/HDFS-8979], and removing the _slf4j_
> logger guards when calling {{LOG.debug()}} and {{LOG.trace()}} can be
> addressed in [HDFS-8971 | https://issues.apache.org/jira/browse/HDFS-8971].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
