[
https://issues.apache.org/jira/browse/HDFS-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736336#comment-14736336
]
Vinayakumar B commented on HDFS-7116:
-------------------------------------
Thanks [~rakeshr] for the effort on this.
Source changes looks great.
Little test improvement required
{code}
+ private void runGetBalancerBandwidthCmd(DFSAdmin admin, String[] args,
+ ClientDatanodeProtocol proxy, long expectedBandwidth) throws Exception {
+ int exitCode = admin.run(args);
+ assertEquals("DFSAdmin should return 0", 0, exitCode);
+ assertEquals("Failed to get the balancer bandwidth!", expectedBandwidth,
+ proxy.getBalancerBandwidth());
+ }
+{code}
I think just verifying the exit code is not enough. Expected bandwidth should
be verified against the output of the command itself instead of getting it
using another dn proxy.
+1 once addressed
> Add a command to get the balancer bandwidth
> -------------------------------------------
>
> Key: HDFS-7116
> URL: https://issues.apache.org/jira/browse/HDFS-7116
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: balancer & mover
> Reporter: Akira AJISAKA
> Assignee: Rakesh R
> Attachments: HDFS-7116-00.patch, HDFS-7116-01.patch,
> HDFS-7116-02.patch, HDFS-7116-03.patch, HDFS-7116-04.patch,
> HDFS-7116-05.patch, HDFS-7116-06.patch, HDFS-7116-07.patch,
> HDFS-7116-08.patch, HDFS-7116-09.patch
>
>
> Now reading logs is the only way to check how the balancer bandwidth is set.
> It would be useful for administrators if they can get the value of the same.
> This jira to discuss & implement the way to access the balancer bandwidth
> value of the datanode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
