[ 
https://issues.apache.org/jira/browse/HDFS-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737286#comment-14737286
 ] 

Kanaka Kumar Avvaru commented on HDFS-8953:
-------------------------------------------

Thanks for the review [~vinayrpet].

1. After HDFS-9009, NN metrics are also configured to NullAppender by default. 
So, we can keep as it is.
2. Yes, some of the attribute values like VolumeInfo are long. So, I avoided 
trim in DN metrics log.
3. Thanks for pointing, I have removed the public accessor in latest patch.

> DataNode Metrics logging
> ------------------------
>
>                 Key: HDFS-8953
>                 URL: https://issues.apache.org/jira/browse/HDFS-8953
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Kanaka Kumar Avvaru
>            Assignee: Kanaka Kumar Avvaru
>         Attachments: HDFS-8953-01.patch, HDFS-8953-02.patch, 
> HDFS-8953-03.patch
>
>
> HDFS-8880 added metrics logging at NameNode. Similarly, this JIRA is to  add 
> a separate logger for metrics at DN



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to