[ 
https://issues.apache.org/jira/browse/HDFS-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739776#comment-14739776
 ] 

Haohui Mai commented on HDFS-9041:
----------------------------------

{code}
+    <resources>
+      <resource>
+        <directory>${basedir}/src/main/resources</directory>
+        <filtering>true</filtering>
+        <includes>
+          <include>META-INF/services/org.apache.hadoop.fs.FileSystem</include>
+        </includes>
+      </resource>
+      <resource>
+        <directory>${basedir}/src/main/resources</directory>
+        <filtering>false</filtering>
+        <excludes>
+          <exclude>META-INF/services/org.apache.hadoop.fs.FileSystem</exclude>
+        </excludes>
+      </resource>
+    </resources>
{code}

There is no need to guard against variable substitution. Digging into the pom 
file a little bit it looks like the maven-resource plugin is loader all the 
time, thus I think it is safe to remove the above code snippet.


> Move entries in META-INF/services/o.a.h.fs.FileSystem to hdfs-client
> --------------------------------------------------------------------
>
>                 Key: HDFS-9041
>                 URL: https://issues.apache.org/jira/browse/HDFS-9041
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Haohui Mai
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9041.000.patch
>
>
> This is a follow up of HDFS-8052. It looks like HDFS-8052 breaks  
> {{TestLocalJobSubmission}} in MR.
> HDFS-8052 moves the implementation of {{WebHdfsFileSystem}} and 
> {{SWebHdfsFileSystem}} to hdfs-client.
> According the usage of ServiceLoader, the corresponding entries in 
> {{hadoop-hdfs-project/hadoop-hdfs/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem}}
>  should be moved as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to