[
https://issues.apache.org/jira/browse/HDFS-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739970#comment-14739970
]
Arpit Agarwal edited comment on HDFS-8953 at 9/11/15 1:20 AM:
--------------------------------------------------------------
Thanks for the heads up [~vinayrpet].
[~kanaka], the patch looks good. Two comments, +1 otherwise
# Can we avoid changing the visibility of DataNode methods for the test case?
It looks like a couple of other tests are already subclassing DataNode.
# {{DataNode#startMetricsLogger(conf)}} should probably be called at the end
of the {{startDataNode}} routine, at least after the DN metrics system is
initialized.
was (Author: arpitagarwal):
Thanks for the heads up [~vinayrpet].
[~kanaka], the patch looks good. Two comments, +1 otherwise
# Can we avoid changing the visibility of DataNode methods for the test case?
It looks like a couple of other tests are already subclassing DataNode.
# {{DataNode#startMetricsLogger(conf)}} should probably be called at the end
of the {{startDataNode}} routine, at least after DN the metrics system is
initialized.
> DataNode Metrics logging
> ------------------------
>
> Key: HDFS-8953
> URL: https://issues.apache.org/jira/browse/HDFS-8953
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kanaka Kumar Avvaru
> Assignee: Kanaka Kumar Avvaru
> Attachments: HDFS-8953-01.patch, HDFS-8953-02.patch,
> HDFS-8953-03.patch
>
>
> HDFS-8880 added metrics logging at NameNode. Similarly, this JIRA is to add
> a separate logger for metrics at DN
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
