[
https://issues.apache.org/jira/browse/HDFS-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790739#comment-14790739
]
Anu Engineer commented on HDFS-8915:
------------------------------------
+1 (Non-Binding)
[~iwasakims] Thanks for fixing this. With this change I presume that test
passes consistently on your local machine. We have not seen this fail in Apache
machines yet, but it is a good to have fix. Test failures does not seem to be
related to this patch.
> TestFSNamesystem.testFSLockGetWaiterCount fails intermittently in jenkins
> -------------------------------------------------------------------------
>
> Key: HDFS-8915
> URL: https://issues.apache.org/jira/browse/HDFS-8915
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: HDFS, test
> Affects Versions: 2.8.0
> Reporter: Anu Engineer
> Assignee: Masatake Iwasaki
> Attachments: HDFS-8915.001.patch
>
>
> This test was added as part of HDFS-8883, There is a race condition in the
> test and it has failed *once* in the Apache Jenkins run.
> Here is the stack
> FAILED:
> org.apache.hadoop.hdfs.server.namenode.TestFSNamesystem.testFSLockGetWaiterCount
> Error Message:
> Expected number of blocked thread not found expected:<3> but was:<1>
> Stack Trace:
> java.lang.AssertionError: Expected number of blocked thread not found
> expected:<3> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at
> org.apache.hadoop.hdfs.server.namenode.TestFSNamesystem.testFSLockGetWaiterCount(TestFSNamesystem.java:261)
> From cursory code reading , even though we call into readlock.lock() there is
> no guarantee that our thread is put in the wait queue. A proposed fix could
> be to check for any thread in the lock queue instead of all 3, or disable the
> test.
> It could also indicate an issue with the test infra-structure but any test
> open to variations in result due to infra-structure issues creates noise in
> tests so we are better off fixing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
