[
https://issues.apache.org/jira/browse/HDFS-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877268#comment-14877268
]
Haohui Mai commented on HDFS-9111:
----------------------------------
The patch looks good to me. Thanks for the work!
{noformat}
+[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java:179:
warning - @See is an unknown tag -- same as a known tag except for case.
{noformat}
{noformat}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java:522:
new DatanodeInfoProto[excludesList.size()])),
{noformat}
+1 after fixing the javadoc and the whitespace warnings.
> Move hdfs-client protobuf convert methods from PBHelper to PBHelperClient
> -------------------------------------------------------------------------
>
> Key: HDFS-9111
> URL: https://issues.apache.org/jira/browse/HDFS-9111
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9111.000.patch
>
>
> *TL;DR* This jira tracks the effort of moving PB helper methods, which
> convert client side data structure to and from protobuf, to the
> {{hadoop-hdfs-client}} module.
> Currently the {{PBHelper}} class contains helper methods converting both
> client and server side data structures from/to protobuf. As we move client
> (and common) classes to {{hadoop-hdfs-client}} module (see [HDFS-8053] and
> [HDFS-9039]), we also need to move client module related PB converters to
> client module.
> A good place may be a new class named {{PBHelperClient}}. After this, the
> existing {{PBHelper}} class stays in {{hadoop-hdfs}} module with converters
> for converting server side data structures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
