[
https://issues.apache.org/jira/browse/HDFS-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901306#comment-14901306
]
Zhe Zhang commented on HDFS-8882:
---------------------------------
Thanks Vinay for the patch. It looks good overall. A couple of comments:
# Should we use {{FSDirErasureCodingOp.getErasureCodingPolicy(fsn, src)}}
instead? A side note is that the multiple {{getErasureCodingPolicy}} methods
are a little confusing. We should clean them up as a follow-on.
{code}
// FSDirWriteFileOp
+ INodesInPath iip = fsn.dir.getINodesInPath4Write(src, false);
+ ecPolicy = FSDirErasureCodingOp.getErasureCodingPolicy(fsn, iip);
{code}
# It would be nice to copy over the Javadoc and comments on the constants from
{{HdfsConstants}} to {{StripedFileTestUtil}}.
> Use datablocks, parityblocks and cell size from ErasureCodingPolicy
> -------------------------------------------------------------------
>
> Key: HDFS-8882
> URL: https://issues.apache.org/jira/browse/HDFS-8882
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-8882-HDFS-7285-01.patch,
> HDFS-8882-HDFS-7285-02.patch
>
>
> As part of earlier development, constants were used for datablocks, parity
> blocks and cellsize.
> Now all these are available in ec zone. Use from there and stop using
> constant values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
