[
https://issues.apache.org/jira/browse/HDFS-9039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-9039:
--------------------------------
Attachment: HDFS-9039.002.patch
Thanks [~wheat9] for your review.
The findbugs warning is caused by the {{Unread public/protected field:
org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider.fallbackToSimpleAuth}}.
As we moved this abstract class to {{hadoop-hdfs-client}} module while keeping
the {{ConfiguredFailoverProxyProvider}} class that extends it stay in
{{hadoop-hdfs}} module, it is better to make the field private in
{{AbstractNNFailoverProxyProvider}}, along with public getter access. The v2
patch addresses this findbugs warning.
> Split o.a.h.hdfs.NameNodeProxies class into two classes in hadoop-hdfs-client
> and hadoop-hdfs modules respectively
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-9039
> URL: https://issues.apache.org/jira/browse/HDFS-9039
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9039.000.patch, HDFS-9039.001.patch,
> HDFS-9039.002.patch
>
>
> Currently the {{org.apache.hadoop.hdfs.NameNodeProxies}} class is used by
> both {{org.apache.hadoop.hdfs.server}} package (for server side protocols)
> and {{DFSClient}} class (for {{ClientProtocol}}). The {{DFSClient}} class
> should be moved to {{hadoop-hdfs-client}} module (see [HDFS-8053 |
> https://issues.apache.org/jira/browse/HDFS-8053]). As the
> {{org.apache.hadoop.hdfs.NameNodeProxies}} class also depends on server side
> protocols (e.g. {{JournalProtocol}} and {{NamenodeProtocol}}), we can't
> simply move this class to the {{hadoo-hdfs-client}} module as well.
> This jira tracks the effort of moving {{ClientProtocol}} related static
> methods in {{org.apache.hadoop.hdfs.NameNodeProxies}} class to
> {{hadoo-hdfs-client}} module. A good place to put these static methods is a
> new class named {{NameNodeProxiesClient}}.
> The checkstyle warnings can be addressed in [HDFS-8979], and removing the
> _slf4j_ logger guards when calling {{LOG.debug()}} and {{LOG.trace()}} can be
> addressed in [HDFS-8971].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
