[ 
https://issues.apache.org/jira/browse/HDFS-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904747#comment-14904747
 ] 

Yongjun Zhang commented on HDFS-9123:
-------------------------------------

Hi Guys, thanks for the review and comments.

{quote}
However, the fact that the source path is the root, does not imply the 
destination path must be its sub-directory. Correct? I mean they do not 
necessarily belong to the same file system.
{quote}
Correct.

About
{quote}
should the tests really downgrade exceptions to logs? I'd expect them to signal 
failure and be rethrown
{quote}
Good point. Since all the tests in this test file are coded like that, I think 
we can create a new jira to fix all of them.
For HDFS-9123, I'd suggest that we should make the newly added test fail when 
without the fix (it currently succeeds as I mentioned earlier), and make it 
succeed when with the fix.

Do you guys agree?

Thanks.


> Copying from the root to a subdirectory should be forbidden
> -----------------------------------------------------------
>
>                 Key: HDFS-9123
>                 URL: https://issues.apache.org/jira/browse/HDFS-9123
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: fs
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Minor
>         Attachments: HDFS-9123.001.patch, HDFS-9123.002.patch
>
>
> HDFS forbids copying from a directory to its subdirectory (e.g. hdfs dfs -cp 
> /abc /abc/xyz) as otherwise it could cause infinite copying (/abc/xyz/xyz, 
> /abc/xyz/xyz, /abc/xyz/xyz/xyz,... etc)
> However, the existing path validation fails if the source path is the root, 
> causing infinite copying, until the disk space is filled up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to