[
https://issues.apache.org/jira/browse/HDFS-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905832#comment-14905832
]
Hadoop QA commented on HDFS-9134:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 19m 48s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 5 new or modified test files. |
| {color:green}+1{color} | javac | 7m 58s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 10s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 26s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 25s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 10s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 161m 2s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests | 0m 30s | Tests passed in
hadoop-hdfs-client. |
| | | 212m 4s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.web.TestWebHDFSOAuth2 |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12762030/HDFS-9134.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1f707ec |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12648/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12648/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12648/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12648/console |
This message was automatically generated.
> Move LEASE_{SOFTLIMIT,HARDLIMIT}_PERIOD constants from HdfsServerConstants to
> HdfsConstants
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-9134
> URL: https://issues.apache.org/jira/browse/HDFS-9134
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9134.000.patch
>
>
> As these two constants are used by {{DFSClient}} which is to be moved to
> {{hadoop-hdfs-client}} module (see [HDFS-8053]), we consider these two
> constants should be moved to {{hadoop-hdfs-client}} module. A good place is
> {{HdfsConstants}} which contains for both server and client side constants.
> This jiras tracks the effort of moving {{LEASE\_SOFTLIMIT\_PERIOD}} and
> {{LEASE_HARDLIMIT\_PERIOD}} constants from server side class
> {{HdfsServerConstants}} to client side class {{HdfsConstants}}. We'd better
> mark these keys as _@Deprecated_ for a while before totally deleting them, in
> case we break dependent code without being aware of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
