[ https://issues.apache.org/jira/browse/HDFS-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942001#comment-14942001 ]
Colin Patrick McCabe commented on HDFS-9188: -------------------------------------------- thanks, [~eddyxu]. {{ReplicaToCorrupt}}: it seems like this should be named something like {{MaterializedReplica}}. Its distinguishing factor is that it is the concrete representation of some replica in the {{FSDataset}}. {code} 92 /** 93 * Corrupt the block file by deleting it. 94 * @return true if the deletion is completed. 95 */ 96 boolean deleteData(); {code} This should be able to throw an IOE. Same with {{deleteMeta}}. > Make block corruption related tests FsDataset-agnostic. > -------------------------------------------------------- > > Key: HDFS-9188 > URL: https://issues.apache.org/jira/browse/HDFS-9188 > Project: Hadoop HDFS > Issue Type: Improvement > Components: HDFS, test > Affects Versions: 2.7.1 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Attachments: HDFS-9188.000.patch, HDFS-9188.001.patch > > > Currently, HDFS does block corruption tests by directly accessing the files > stored on the storage directories, which assumes {{FsDatasetImpl}} is the > dataset implementation. However, with works like OZone (HDFS-7240) and > HDFS-8679, there will be different FsDataset implementations. > So we need a general way to run whitebox tests like corrupting blocks and crc > files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)