[ 
https://issues.apache.org/jira/browse/HDFS-9142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943562#comment-14943562
 ] 

Ming Ma commented on HDFS-9142:
-------------------------------

Thanks [~l201514] for identifying the issue. Having each namenode use its own 
Configuration should work.

* Why is the removal of {{if (!federation && lastDefaultFileSystem != null)}}? 
That is still needed for non federated case? It might explain the test failure.
* Some code can be shared in the two steps a) set up the nameservice related 
configs for each newly created NN. b) copy all NNs's nameservice related 
configs to the all NNs. In both case, it needs something like {{private static 
void copyKeys(Configuration srcConf, Configuration destConf, String 
nameserviceId, String nnId)}}, where it copies RPC/HTTP/HTTPS addresses for the 
specific nameservice/nnid from some conf to another conf. 

> Namenode Http address is not configured correctly for federated cluster in 
> MiniDFSCluster
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-9142
>                 URL: https://issues.apache.org/jira/browse/HDFS-9142
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Siqi Li
>            Assignee: Siqi Li
>         Attachments: HDFS-9142.v1.patch, HDFS-9142.v2.patch, 
> HDFS-9142.v3.patch, HDFS-9142.v4.patch
>
>
> When setting up simpleHAFederatedTopology in MiniDFSCluster, each Namenode 
> should have its own configuration object, and the configuration should have 
> "dfs.namenode.http-address-<nameservice>-<namenodeid>" set up correctly for 
> all <nameserivce, namenodeid> pair



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to