[
https://issues.apache.org/jira/browse/HDFS-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943884#comment-14943884
]
Yongjun Zhang commented on HDFS-8164:
-------------------------------------
Thanks [~vinayrpet] for the review and [~xiaochen] for the new rev.
It looks good, couple of small things:
1. comment for {{getCTime}}, the return value section is not correct, suggest
to change to something like:
{code}
/**
* Get the creation time of the file system.
* Notice that this time is initialized to NameNode format time, and updated
* to upgrade time during upgrades.
* @return time in milli seconds. See {@link
org.apache.hadoop.util.Time#now()}.
*/
{code}
2. Suggest to change the assertion in the test code to (<= instead of <).
{code}
assertTrue(ctime <= post);
{code}
Thanks.
> cTime is 0 in VERSION file for newly formatted NameNode.
> --------------------------------------------------------
>
> Key: HDFS-8164
> URL: https://issues.apache.org/jira/browse/HDFS-8164
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.0.3-alpha
> Reporter: Chris Nauroth
> Assignee: Xiao Chen
> Priority: Minor
> Attachments: HDFS-8164.001.patch, HDFS-8164.002.patch,
> HDFS-8164.003.patch, HDFS-8164.004.patch, HDFS-8164.005.patch
>
>
> After formatting a NameNode and inspecting its VERSION file, the cTime
> property shows 0. The value does get updated to current time during an
> upgrade, but I believe this is intended to be the creation time of the
> cluster, and therefore the initial value of 0 before an upgrade can cause
> confusion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
