[
https://issues.apache.org/jira/browse/HDFS-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uma Maheswara Rao G updated HDFS-9182:
--------------------------------------
Attachment: HDFSS-9182.00.patch
Attached a patch to address the findbugs and release audit warnings.
Changes are as follows:
1) Added to excludes list for EI_EXPOSE_REP,EI_EXPOSE_REP2 type comments as as
already added them in hadoop-hdfs-project.After moving to hfs-client project we
should add file names explicitly.
2) DFSOutputStream#currentPacket inconsistent synchronization because
enqueueCurrentPacketFull is package scoped and a non synchronized method, here
it is accessing currentPacket. This is the concern for findbags. Currently
enqueueCurrentPacketFull called only in writeChunk which is already
synchronized, so logically there is no issue. But to exclude such comments
options to mention the field name which can avoid the comment, but the issue is
it may suppress future warnings as well. So to make windbags happy I just made
enqueueCurrentPacketFull synchronized, I think its ok.
3) Merged the HDFS-7285 related CHANGES.txt to main CHANGES.txt.
I also took chance to place two of the issue entries in CHANGES.txt, which was
placed wrongly like HDFS lira entry in Common and vise versa.
Following 2 are such type:
HADOOP-11921. Enhance tests for erasure coders. (Kai Zheng)
HDFS-8557. Allow to configure RS and XOR raw coders (Kai Zheng)
> Cleanup the findbugs and other issues after HDFS EC merged to trunk.
> --------------------------------------------------------------------
>
> Key: HDFS-9182
> URL: https://issues.apache.org/jira/browse/HDFS-9182
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Yi Liu
> Assignee: Uma Maheswara Rao G
> Priority: Critical
> Attachments: HDFSS-9182.00.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-client.html
> https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/patchReleaseAuditProblems.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
