[
https://issues.apache.org/jira/browse/HDFS-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944765#comment-14944765
]
Vinayakumar B commented on HDFS-9159:
-------------------------------------
Thanks [~nijel] for the patch.
Overall looks good.
Have 2 nits.
1. Indentation of default case can be corrected as per other cases.
2. Typo in assertion statement of test. "Status code retrun on invalid
processor is not correct"
> [OIV] : return value of the command is not correct if invalid value specified
> in "-p (processor)" option
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-9159
> URL: https://issues.apache.org/jira/browse/HDFS-9159
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: nijel
> Assignee: nijel
> Attachments: HDFS-9159_01.patch, HDFS-9159_02.patch
>
>
> Return value of the IOV command is not correct if invalid value specified in
> "-p (processor)" option
> this needs to return error to user.
> code change will be in switch statement of
> {code}
> try (PrintStream out = outputFile.equals("-") ?
> System.out : new PrintStream(outputFile, "UTF-8")) {
> switch (processor) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
