[
https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945578#comment-14945578
]
Jing Zhao commented on HDFS-9129:
---------------------------------
The patch looks good overall. Some early comments:
# The jira currently divides the original safemode into several different
parts: manual safemode, safemode caused by low resource, and safemode related
to blocks and datanodes. It will be helpful for others to understand the change
if you can post a more detailed design about the approach.
# Instead of dumping all the safemodeInfo details directly into BlockManager,
it's better to have a standalone class for SafeModeInfo in blockmanagement
package.
# The {{FSNamesystem#leaveSafeMode}} method can delegate the operation to the
BlockManager's safemode instead of directly operating on BlockManager's
internal states.
> Move the safemode block count into BlockManager
> -----------------------------------------------
>
> Key: HDFS-9129
> URL: https://issues.apache.org/jira/browse/HDFS-9129
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Mingliang Liu
> Attachments: HDFS-9129.000.patch, HDFS-9129.001.patch
>
>
> The {{SafeMode}} needs to track whether there are enough blocks so that the
> NN can get out of the safemode. These fields can moved to the
> {{BlockManager}} class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
