[
https://issues.apache.org/jira/browse/HDFS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947325#comment-14947325
]
Allen Wittenauer commented on HDFS-9114:
----------------------------------------
At this point, I'm -1 this change.
This log file is effectively a metrics sink. Like all other metric sinks, it
should be configured via the metrics2 API using those constructs. This
particular sink bypasses all of that configuration and has it's own custom
configuration. There's zero reason to impact effectively the entire rest of the
Hadoop platform with that poorly thought out decision (for what is essentially
a debug mode) which is what this patch currently does.
Essentially, you've got two choices:
a) if you want this patch to go forward, you're going to have to do it without
hitting the shell code and without making any configuration bits appear to be
from the metrics2 subsystem (which is what hadoop.metrics implies)
b) Revert HDFS-8880 and rewrite this logging mechanism to actually be a
metrics2 sink, which would allow you to keep names such as hadoop.metrics
> NameNode and DataNode metric log file name should follow the other log file
> name format.
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-9114
> URL: https://issues.apache.org/jira/browse/HDFS-9114
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-9114-branch-2.01.patch,
> HDFS-9114-branch-2.02.patch, HDFS-9114-trunk.01.patch,
> HDFS-9114-trunk.02.patch
>
>
> Currently datanode and namenode metric log file name is
> {{datanode-metrics.log}} and {{namenode-metrics.log}}.
> This file name should be like {{hadoop-hdfs-namenode-metric-host192.log}}
> same as namenode log file {{hadoop-hdfs-namenode-host192.log}}.
> This will help when we will copy log for issue analysis from different node.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
