[
https://issues.apache.org/jira/browse/HDFS-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947531#comment-14947531
]
Jing Zhao commented on HDFS-9204:
---------------------------------
The patch looks good to me. Some minors:
# We can add an assertion here to make sure there is exactly one element in
srcNodes.
{code}
getSrcNodes()[0].incrementPendingReplicationWithoutTargets();
{code}
# We can use Whitebox to access {{pendingReplicationWithoutTargets}} instead of
changing its access label.
+1 after addressing the comments.
> DatanodeDescriptor#PendingReplicationWithoutTargets is wrongly calculated
> -------------------------------------------------------------------------
>
> Key: HDFS-9204
> URL: https://issues.apache.org/jira/browse/HDFS-9204
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Jing Zhao
> Assignee: Mingliang Liu
> Attachments: HDFS-9204.000.patch
>
>
> This seems to be a regression caused by the merge of EC feature branch.
> {{DatanodeDescriptor#incrementPendingReplicationWithoutTargets}}, which is
> added by HDFS-7128 to fix a bug during DN decommission, is no longer called
> when creating ReplicationWork.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
