[
https://issues.apache.org/jira/browse/HDFS-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948168#comment-14948168
]
Vinayakumar B commented on HDFS-8630:
-------------------------------------
Thanks [~surendrasingh] for working on this.
Have few comments
1. Need to rebase the patch with latest trunk code.
2. Some places formatting is not proper, so please format code for changed lines
3. In WebHdfsFileSystem.java {{XAttrEncodingParam}} not required to pass.
{code}+ return new FsPathResponseRunner<Collection<? extends
BlockStoragePolicySpi>>(
+ op, null, new XAttrEncodingParam(XAttrCodec.HEX)) {{code}
4. In Tests, {{testGetAllStoragePolicy}}, I think you are just doing duplicate
work. webhdfs also uses HTTP to get storage policies, and you are explicitly
querying via PUT request. I think it would be better to get expected values via
DFS, and actual values via both WebHDFS and direct PUT query.
5. Same #4, In {{testGetandSetStoragePolicy}}, each operation you can cross
verify again by using DFS.
> WebHDFS : Support get/setStoragePolicy
> ---------------------------------------
>
> Key: HDFS-8630
> URL: https://issues.apache.org/jira/browse/HDFS-8630
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: nijel
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-8630.001.patch, HDFS-8630.patch
>
>
> User can set and get the storage policy from filesystem object. Same
> operation can be allowed trough REST API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
