[
https://issues.apache.org/jira/browse/HDFS-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954290#comment-14954290
]
Tsz Wo Nicholas Sze commented on HDFS-9223:
-------------------------------------------
Since getCapacityUsedPercent, getCapacityRemainingPercent,
getPercentBlockPoolUsed, getCapacityUsedNonDFS call multiple stats methods, we
should also add them to the new class and synchronize them.
> ... I will check this code to confirm and maybe we can do this change
> separately.
Sure, please check the code and do it separately.
> Code cleanup for DatanodeDescriptor and HeartbeatManager
> --------------------------------------------------------
>
> Key: HDFS-9223
> URL: https://issues.apache.org/jira/browse/HDFS-9223
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Priority: Minor
> Attachments: HDFS-9223.000.patch, HDFS-9223.001.patch
>
>
> Some code cleanup for {{DatanodeDescriptor}} and {{HeartbeatManager}}. The
> changes include:
> # Change {{DataDescriptor#isAlive}} and {{DatanodeDescriptor#needKeyUpdate}}
> from public to private
> # Use EnumMap for {{HeartbeatManager#storageTypeStatesMap}}
> # Move the {{isInStartupSafeMode}} out of the namesystem lock in
> {{heartbeatCheck}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
