[
https://issues.apache.org/jira/browse/HDFS-9245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960033#comment-14960033
]
Hadoop QA commented on HDFS-9245:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 18m 6s | Pre-patch trunk has 2 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 49s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 22s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 26s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 25s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 38s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 55s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings. |
| {color:green}+1{color} | native | 3m 40s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 1m 53s | Tests passed in
hadoop-hdfs-nfs. |
| | | 47m 54s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12766930/HDFS-9245.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cf23f2c |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/13019/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html
|
| hadoop-hdfs-nfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/13019/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/13019/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/13019/console |
This message was automatically generated.
> Fix findbugs warnings in hdfs-nfs/WriteCtx
> ------------------------------------------
>
> Key: HDFS-9245
> URL: https://issues.apache.org/jira/browse/HDFS-9245
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9245.000.patch
>
>
> There are findbugs warnings as follows, brought by [HDFS-9092].
> It seems fine to ignore them by write a filter rule in the
> {{findbugsExcludeFile.xml}} file.
> {code:xml}
> <BugInstance rank="17" category="MT_CORRECTNESS"
> instanceHash="592511935f7cb9e5f97ef4c99a6c46c2" instanceOccurrenceNum="0"
> priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366"
> instanceOccurrenceMax="0">
> <ShortMessage>Inconsistent synchronization</ShortMessage>
> <LongMessage>
> Inconsistent synchronization of
> org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.offset; locked 75% of time
> </LongMessage>
> <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
> <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java"
> sourcefile="WriteCtx.java" end="314">
> <Message>At WriteCtx.java:[lines 40-314]</Message>
> </SourceLine>
> <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
> </Class>
> {code}
> and
> {code:xml}
> <BugInstance rank="17" category="MT_CORRECTNESS"
> instanceHash="4f3daa339eb819220f26c998369b02fe" instanceOccurrenceNum="0"
> priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366"
> instanceOccurrenceMax="0">
> <ShortMessage>Inconsistent synchronization</ShortMessage>
> <LongMessage>
> Inconsistent synchronization of
> org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount; locked 50% of time
> </LongMessage>
> <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
> <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java"
> sourcefile="WriteCtx.java" end="314">
> <Message>At WriteCtx.java:[lines 40-314]</Message>
> </SourceLine>
> <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
> </Class>
> <Field isStatic="false" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> name="originalCount" primary="true" signature="I">
> <SourceLine classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java"
> sourcefile="WriteCtx.java">
> <Message>In WriteCtx.java</Message>
> </SourceLine>
> <Message>
> Field org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount
> </Message>
> </Field>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
