[
https://issues.apache.org/jira/browse/HDFS-9070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962176#comment-14962176
]
J.Andreina commented on HDFS-9070:
----------------------------------
Thanks [~demongaorui] ,recent changes Looks good.
Some nits:
1.
{code}
+ } else if (isComplete && corruptReplicas != null
+ && corruptReplicas.contains(dnDesc)) {
+ sb.append("CORRUPT)");
+ } else if (isComplete && blocksExcess != null
+ && blocksExcess.contains(storedBlock)) {
+ sb.append("EXCESS)");
{code}
I don't think *isComplete()* check is required in above code .
Block can be CORRUPT or EXCESS, logically possible only if it is complete. So
explicit check might not be required.
2. Test {{testFsckOpenECFiles}} is written for EC files, but changes are not
specific to EC file, and there is nothing asserted against EC related. Hence
when the test is run, it takes lot of time, since it involves 10 DNs.
IMO, its okay to test samething with normal non-EC file.
> Allow fsck display pending replica location information for being-written
> blocks
> --------------------------------------------------------------------------------
>
> Key: HDFS-9070
> URL: https://issues.apache.org/jira/browse/HDFS-9070
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: GAO Rui
> Assignee: GAO Rui
> Attachments: HDFS-9070--HDFS-7285.00.patch,
> HDFS-9070-HDFS-7285.00.patch, HDFS-9070-HDFS-7285.01.patch,
> HDFS-9070-HDFS-7285.02.patch, HDFS-9070-trunk.03.patch,
> HDFS-9070-trunk.04.patch, HDFS-9070-trunk.05.patch, HDFS-9070-trunk.06.patch
>
>
> When a EC file is being written, it can be helpful to allow fsck display
> datanode information of the being-written EC file block group.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
