[
https://issues.apache.org/jira/browse/HDFS-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962229#comment-14962229
]
Rakesh R commented on HDFS-9229:
--------------------------------
Thank you [~surendrasingh] for the contribution, patch looks almost good. Just
few comments, please take a look at it.
# Unit is missing, please add it. (for example, in bytes)
{code}
+| `NameDirSize` | NameNode name directories size|
{code}
# In tests, it would be good to assert the the size of the {{nnDirMap.size()}}.
Presently it will miss the assertion and won't fail the test if the map wrongly
returns the content with zero length, right?
{code}
+ Map<String, Long> nnDirMap =
+ (Map<String, Long>) JSON.parse(
+ (String) mbs.getAttribute(mxbeanName, "NameDirSize"));
{code}
# Also, there are couple of checkstyle warnings related to the patch, please
take care. Thanks!
> Expose size of NameNode directory as a metric
> ---------------------------------------------
>
> Key: HDFS-9229
> URL: https://issues.apache.org/jira/browse/HDFS-9229
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.7.1
> Reporter: Zhe Zhang
> Assignee: Surendra Singh Lilhore
> Priority: Minor
> Attachments: HDFS-9229.001.patch
>
>
> Useful for admins in reserving / managing NN local file system space. Also
> useful when transferring NN backups.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
