[
https://issues.apache.org/jira/browse/HDFS-8631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963013#comment-14963013
]
J.Andreina commented on HDFS-8631:
----------------------------------
Thanks [~surendrasingh] for the patch.
It looks great.
I have few comments :
1.
Both in NamespaceQuotaParam and in StoragespaceQuotaParam, can update below as
default value:
{code}
public static final String DEFAULT =
String.valueOf(HdfsConstants.QUOTA_DONT_SET);
instead of
public static final String DEFAULT = String.valueOf(Long.MAX_VALUE);
{code}
2.
Both in NamespaceQuotaParam and in StoragespaceQuotaParam, can update the
constructor code as below for more readability
{code}
super(DOMAIN, value, HdfsConstants.QUOTA_RESET, null);
instead of
super(DOMAIN, value, -1L, null);
{code}
3.
Inorder to make test run faster, start 0 datanodes in both testcases, as there
is no file is been written in tests.
4.
Can update the webhdfs document for supporting list/setQuota.
> WebHDFS : Support list/setQuota
> -------------------------------
>
> Key: HDFS-8631
> URL: https://issues.apache.org/jira/browse/HDFS-8631
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: nijel
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-8631-001.patch
>
>
> User is able do quota management from filesystem object. Same operation can
> be allowed trough REST API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
