[
https://issues.apache.org/jira/browse/HDFS-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986773#action_12986773
]
Todd Lipcon commented on HDFS-1597:
-----------------------------------
bq. As of HDFS-119 syntxid is set in the finally block, even if the sync was
batched
Sorry, didn't say that very clearly. If the sync is batched, it will set
{{synctxid}} to *0* in the {{finally}} block! So the next thread comes along,
doesn't think it has been batched (though it has) and do yet another sync.
> Misplaced assertion in FSEditLog.logSync
> ----------------------------------------
>
> Key: HDFS-1597
> URL: https://issues.apache.org/jira/browse/HDFS-1597
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: illustrate-test-failure.txt
>
>
> The top of FSEditLog.logSync has the following assertion:
> {code}
> assert editStreams.size() > 0 : "no editlog streams";
> {code}
> which should actually come after checking to see if the sync was already
> batched in by another thread.
> Will describe the race in a comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
