[
https://issues.apache.org/jira/browse/HDFS-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967525#comment-14967525
]
Xiao Chen commented on HDFS-9231:
---------------------------------
patch 004 is attached. I think I should re-summarize it below:
- fsck from command line with {{-includeSnapshots}} will also show full dir of
snapshots
- fsck from command line without {{-includeSnapshots}} behavior unchanged
- NameNode WebUI's way of showing corrupted files/blocks unchanged.
- Added a sentence in NN WebUI to hint the admin to run fsck with
{{-includeSnapshots}} if there're snapshots present in the system.
- Some refactoring to reuse existing code in new methods
{{getSnapshottableDirs}} and {{ListCorruptFileBlocksWithSnapshot}}
- The reasoning of keep minimal change to NN WebUI and fsck without
{{-includeSnapshots}} is that getting all possible snapshots may be slow, since
it's user configured.
> fsck doesn't explicitly list when Bad Replicas/Blocks are in a snapshot
> -----------------------------------------------------------------------
>
> Key: HDFS-9231
> URL: https://issues.apache.org/jira/browse/HDFS-9231
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: snapshots
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HDFS-9231.001.patch, HDFS-9231.002.patch,
> HDFS-9231.003.patch, HDFS-9231.004.patch
>
>
> For snapshot files, fsck shows corrupt blocks with the original file dir
> instead of the snapshot dir.
> This can be confusing since even when the original file is deleted, a new
> fsck run will still show that file as corrupted although what's actually
> corrupted is the snapshot.
> This is true even when given the -includeSnapshots option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
