[ 
https://issues.apache.org/jira/browse/HDFS-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968797#comment-14968797
 ] 

Yi Liu commented on HDFS-9275:
------------------------------

Walter, please add some description in the JIRA description part about what 
issue in the Test you want to fix? It's better to have Jenkins failure link if 
there is.

I see you replace {{setDataNodesDead}} and {{readReplica}} with some existing 
methods in other Test Utils, that's good.

In the tests, originally I restart the datanodes at the end of tests because I 
intended to share same mini cluster to make tests faster, but I forgot to use 
{{@BeforeClass}} instead of {{Before}} which will do the restart for each test. 
 I am OK to just remove starting shutdown DNs at the end.

> Fix TestRecoverStripedFile
> --------------------------
>
>                 Key: HDFS-9275
>                 URL: https://issues.apache.org/jira/browse/HDFS-9275
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-9275.01.patch, HDFS-9275.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to