[ https://issues.apache.org/jira/browse/HDFS-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970453#comment-14970453 ]
Hadoop QA commented on HDFS-9241: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 21m 22s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 9m 0s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 11m 45s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 25s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 2m 54s | The applied patch generated 1 new checkstyle issues (total was 104, now 104). | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 53s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 4m 56s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 3m 44s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 54m 47s | Tests failed in hadoop-hdfs. | | {color:green}+1{color} | hdfs tests | 0m 34s | Tests passed in hadoop-hdfs-client. | | | | 111m 59s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.fs.contract.hdfs.TestHDFSContractMkdir | | | hadoop.hdfs.qjournal.TestMiniJournalCluster | | | hadoop.cli.TestDeleteCLI | | | hadoop.hdfs.TestFileLengthOnClusterRestart | | | hadoop.hdfs.TestAppendSnapshotTruncate | | | hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory | | | hadoop.cli.TestHDFSCLI | | | hadoop.hdfs.TestReplaceDatanodeOnFailure | | | hadoop.hdfs.TestDFSStorageStateRecovery | | | hadoop.fs.contract.hdfs.TestHDFSContractRename | | | hadoop.cli.TestCacheAdminCLI | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | | | hadoop.fs.loadGenerator.TestLoadGenerator | | | hadoop.fs.TestFcHdfsSetUMask | | | hadoop.hdfs.crypto.TestHdfsCryptoStreams | | | hadoop.fs.viewfs.TestViewFsFileStatusHdfs | | | hadoop.tracing.TestTracingShortCircuitLocalRead | | | hadoop.tracing.TestTracing | | | hadoop.hdfs.TestDFSStripedInputStream | | | hadoop.fs.TestWebHdfsFileContextMainOperations | | | hadoop.hdfs.TestParallelShortCircuitReadNoChecksum | | | hadoop.hdfs.TestParallelShortCircuitLegacyRead | | | hadoop.net.TestNetworkTopology | | | hadoop.fs.TestFcHdfsCreateMkdir | | | hadoop.fs.TestFcHdfsPermission | | | hadoop.hdfs.TestQuota | | | hadoop.hdfs.qjournal.server.TestJournal | | | hadoop.hdfs.TestDFSStartupVersions | | | hadoop.fs.viewfs.TestViewFsWithXAttrs | | | hadoop.cli.TestErasureCodingCLI | | | hadoop.tools.TestJMXGet | | | hadoop.TestGenericRefresh | | | hadoop.hdfs.TestRecoverStripedFile | | | hadoop.hdfs.TestDataTransferKeepalive | | | hadoop.fs.TestSWebHdfsFileContextMainOperations | | | hadoop.fs.contract.hdfs.TestHDFSContractDelete | | | hadoop.fs.contract.hdfs.TestHDFSContractSetTimes | | | hadoop.hdfs.TestConnCache | | | hadoop.hdfs.TestFileAppend | | | hadoop.hdfs.TestReadStripedFileWithDecoding | | | hadoop.TestRefreshCallQueue | | | hadoop.hdfs.TestDisableConnCache | | | hadoop.cli.TestXAttrCLI | | | hadoop.fs.TestUrlStreamHandler | | | hadoop.tools.TestTools | | | hadoop.fs.TestEnhancedByteBufferAccess | | | hadoop.hdfs.TestRollingUpgrade | | | hadoop.fs.viewfs.TestViewFileSystemWithXAttrs | | | hadoop.fs.TestHDFSFileContextMainOperations | | | hadoop.hdfs.qjournal.client.TestEpochsAreUnique | | | hadoop.hdfs.TestExternalBlockReader | | | hadoop.fs.contract.hdfs.TestHDFSContractAppend | | | hadoop.hdfs.TestDFSStripedOutputStream | | | hadoop.hdfs.TestHdfsAdmin | | | hadoop.fs.contract.hdfs.TestHDFSContractOpen | | | hadoop.hdfs.TestFileCreation | | | hadoop.hdfs.TestClientReportBadBlock | | | hadoop.tracing.TestTraceAdmin | | | hadoop.hdfs.TestAbandonBlock | | | hadoop.hdfs.TestDFSInputStream | | | hadoop.hdfs.TestWriteBlockGetsBlockLengthHint | | | hadoop.fs.viewfs.TestViewFsHdfs | | | hadoop.fs.contract.hdfs.TestHDFSContractConcat | | | hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot | | | hadoop.cli.TestCryptoAdminCLI | | | hadoop.hdfs.TestFileCreationDelete | | | hadoop.hdfs.qjournal.server.TestJournalNodeMXBean | | | hadoop.hdfs.TestReplication | | | hadoop.cli.TestAclCLI | | | hadoop.fs.viewfs.TestViewFileSystemWithAcls | | | hadoop.fs.TestSymlinkHdfsFileContext | | | hadoop.fs.TestSymlinkHdfsFileSystem | | | hadoop.hdfs.TestFileAppend3 | | | hadoop.fs.TestUnbuffer | | | hadoop.hdfs.qjournal.client.TestQuorumJournalManager | | | hadoop.hdfs.qjournal.TestSecureNNWithQJM | | | hadoop.fs.viewfs.TestViewFsWithAcls | | | hadoop.fs.TestResolveHdfsSymlink | | | hadoop.hdfs.TestFileConcurrentReader | | | hadoop.fs.viewfs.TestViewFsDefaultValue | | | hadoop.hdfs.qjournal.server.TestJournalNode | | | hadoop.hdfs.qjournal.client.TestIPCLoggerChannel | | | hadoop.fs.contract.hdfs.TestHDFSContractGetFileStatus | | | hadoop.fs.viewfs.TestViewFileSystemHdfs | | | hadoop.hdfs.TestParallelUnixDomainRead | | | hadoop.hdfs.qjournal.client.TestQJMWithFaults | | | hadoop.hdfs.TestDFSRemove | | | hadoop.fs.viewfs.TestViewFsAtHdfsRoot | | | hadoop.hdfs.qjournal.TestNNWithQJM | | | hadoop.hdfs.TestFileCreationClient | | | hadoop.fs.contract.hdfs.TestHDFSContractCreate | | | hadoop.fs.permission.TestStickyBit | | | hadoop.hdfs.TestEncryptionZonesWithKMS | | | hadoop.fs.TestSymlinkHdfsDisable | | | hadoop.hdfs.TestDFSUtil | | | hadoop.hdfs.TestLease | | | hadoop.fs.TestGlobPaths | | | hadoop.hdfs.TestWriteStripedFileWithFailure | | | hadoop.fs.contract.hdfs.TestHDFSContractSeek | | | hadoop.fs.shell.TestHdfsTextCommand | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12768203/HDFS-9241.005.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 124a412 | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/13145/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/13145/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/13145/artifact/patchprocess/testrun_hadoop-hdfs.txt | | hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/13145/artifact/patchprocess/testrun_hadoop-hdfs-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/13145/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/13145/console | This message was automatically generated. > HDFS clients can't construct HdfsConfiguration instances > -------------------------------------------------------- > > Key: HDFS-9241 > URL: https://issues.apache.org/jira/browse/HDFS-9241 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Reporter: Steve Loughran > Assignee: Mingliang Liu > Attachments: HDFS-9241.000.patch, HDFS-9241.001.patch, > HDFS-9241.002.patch, HDFS-9241.003.patch, HDFS-9241.004.patch, > HDFS-9241.005.patch > > > the changes for the hdfs client classpath make instantiating > {{HdfsConfiguration}} from the client impossible; it only lives server side. > This breaks any app which creates one. > I know people will look at the {{@Private}} tag and say "don't do that then", > but it's worth considering precisely why I, at least, do this: it's the only > way to guarantee that the hdfs-default and hdfs-site resources get on the > classpath, including all the security settings. It's precisely the use case > which {{HdfsConfigurationLoader.init();}} offers internally to the hdfs code. > What am I meant to do now? -- This message was sent by Atlassian JIRA (v6.3.4#6332)