[ 
https://issues.apache.org/jira/browse/HDFS-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei-Chiu Chuang updated HDFS-7284:
----------------------------------
    Attachment: HDFS-7284.003.patch

[~yzhangal] Good idea! 
The output of your suggested change is:
2015-10-23 10:21:18,647 [IPC Server handler 7 on 51002] DEBUG BlockStateChange 
(BlockInfo.java:setGenerationStampAndVerifyReplicas(396)) - BLOCK* Removing 
stale replica 
ReplicaUC[[DISK]DS-b87b985d-6dc7-448e-9d45-dcd6c2c8ec37:NORMAL:127.0.0.1:51003|RBW]
 of blk_1073741826_1002

Attaching rev3 based on Yongjun's suggestion.

> Add more debug info to 
> BlockInfoUnderConstruction#setGenerationStampAndVerifyReplicas
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-7284
>                 URL: https://issues.apache.org/jira/browse/HDFS-7284
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.5.1
>            Reporter: Hu Liu,
>            Assignee: Wei-Chiu Chuang
>              Labels: supportability
>         Attachments: HDFS-7284.001.patch, HDFS-7284.002.patch, 
> HDFS-7284.003.patch
>
>
> When I was looking at some replica loss issue, I got the following info from 
> log
> {code}
> 2014-10-13 01:54:53,104 INFO BlockStateChange: BLOCK* Removing stale replica 
> from location x.x.x.x
> {code}
> I could just know that a replica is removed, but I don't know which block and 
> its timestamp. I need to know the id and timestamp of the block from the log 
> file.
> So it's better to add more info including block id and timestamp to the code 
> snippet
> {code}
>     for (ReplicaUnderConstruction r : replicas) {
>       if (genStamp != r.getGenerationStamp()) {
>         r.getExpectedLocation().removeBlock(this);
>         NameNode.blockStateChangeLog.info("BLOCK* Removing stale replica "
>             + "from location: " + r.getExpectedLocation());
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to