[ 
https://issues.apache.org/jira/browse/HDFS-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971893#comment-14971893
 ] 

Chang Li commented on HDFS-9298:
--------------------------------

Thanks for valuable review [~jingzhao]! Understand the situation you describe. 
But could we check if replica has genStamp lesser than the current one?

> remove replica and not add replica with wrong genStamp
> ------------------------------------------------------
>
>                 Key: HDFS-9298
>                 URL: https://issues.apache.org/jira/browse/HDFS-9298
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: HDFS-9298.1.patch
>
>
> currently, in setGenerationStampAndVerifyReplicas, replica with wrong gen 
> stamp is not really removed, only StorageLocation of that replica is removed. 
> Moreover, we should check genStamp before addReplicaIfNotPresent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to