[
https://issues.apache.org/jira/browse/HDFS-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976841#comment-14976841
]
Jing Zhao commented on HDFS-9168:
---------------------------------
Patch looks good to me. One nit is that we can use this chance to fix the
condition (2) in the following javadoc
{code}
37 * Add a new datanode only if r >= 3 and either
38 * (1) floor(r/2) >= n; or
39 * (2) r > n and the block is hflushed/appended.
40 */
{code}
Also please generally explain why the changes in {{ReplaceDatanodeOnFailure}}
is necessary. +1 after addressing the comments.
> Move client side unit test to hadoop-hdfs-client
> ------------------------------------------------
>
> Key: HDFS-9168
> URL: https://issues.apache.org/jira/browse/HDFS-9168
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: build
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-9168.000.patch, HDFS-9168.001.patch,
> HDFS-9168.002.patch, HDFS-9168.003.patch
>
>
> We need to identify and move the unit tests on the client of hdfs to the
> hdfs-client module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
